# HG changeset patch # User Matt Harbison # Date 1639527210 18000 # Node ID 81805bba11f91f7c58a5a0ab5eff461b0ff139b4 # Parent 12a43f857a11c26da151d078dd9f95a7131c6aef pytype: stop excluding wireprotoserver.py The `config` entry is a 2 part tuple, which has `__iter__()`: File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] In Union[Callable[[Any, Any, Any, Any, Any], None], Callable[[Any, Any], Any]] File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any, Any, Any, Any], None] [attribute-error] In Union[Callable[[Any, Any, Any, Any, Any], None], Callable[[Any, Any], Any]] Differential Revision: https://phab.mercurial-scm.org/D11930 diff -r 12a43f857a11 -r 81805bba11f9 mercurial/wireprotoserver.py --- a/mercurial/wireprotoserver.py Tue Dec 14 18:36:07 2021 -0500 +++ b/mercurial/wireprotoserver.py Tue Dec 14 19:13:30 2021 -0500 @@ -250,7 +250,7 @@ # Registered APIs are made available via config options of the name of # the protocol. for k, v in API_HANDLERS.items(): - section, option = v[b'config'] + section, option = v[b'config'] # pytype: disable=attribute-error if repo.ui.configbool(section, option): apis.add(k) diff -r 12a43f857a11 -r 81805bba11f9 tests/test-check-pytype.t --- a/tests/test-check-pytype.t Tue Dec 14 18:36:07 2021 -0500 +++ b/tests/test-check-pytype.t Tue Dec 14 19:13:30 2021 -0500 @@ -34,7 +34,6 @@ mercurial/utils/memorytop.py # not 3.6 compatible mercurial/win32.py # [not-callable] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] -mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs @@ -68,7 +67,6 @@ > -x mercurial/utils/memorytop.py \ > -x mercurial/win32.py \ > -x mercurial/wireprotoframing.py \ - > -x mercurial/wireprotoserver.py \ > -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1server.py \ > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt