# HG changeset patch # User Martin von Zweigbergk # Date 1538496678 25200 # Node ID 825a636812a4af8ee52f6460024fb5e1afc43247 # Parent 731961d972ba9ff5e3d473846e711b609121b496 narrow: avoid overwriting a variable I don't like to overwrite variables, especially not with a different type (because it makes it harder to explain what the variable is for, and, therefore, to name it well). Differential Revision: https://phab.mercurial-scm.org/D4846 diff -r 731961d972ba -r 825a636812a4 hgext/narrow/narrowbundle2.py --- a/hgext/narrow/narrowbundle2.py Thu Sep 27 20:16:48 2018 -0700 +++ b/hgext/narrow/narrowbundle2.py Tue Oct 02 09:11:18 2018 -0700 @@ -67,11 +67,10 @@ """ # XXX: This patch will start sending bundle2 after couple of patches when # called from the wireprotocol command - common = repo.revs("::%ln", common) commonnodes = set() cl = repo.changelog - for c in common: - commonnodes.add(cl.node(c)) + for r in repo.revs("::%ln", common): + commonnodes.add(cl.node(r)) if commonnodes: # XXX: we should only send the filelogs (and treemanifest). user # already has the changelog and manifest