# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1621257886 -7200
# Node ID 8b2d09c7e5cdaf53566ee9f3f30ed769810eeda8
# Parent  7edaf91c7886fa8d7ebd71af021fdcb509beb04c
updatecaches: deprecate the `full` argument

Now that all users were migrated, we can use deprecate the old way. This would
give potential extensions code a heads up on the API change.

Differential Revision: https://phab.mercurial-scm.org/D10731

diff -r 7edaf91c7886 -r 8b2d09c7e5cd mercurial/localrepo.py
--- a/mercurial/localrepo.py	Mon May 17 15:42:18 2021 +0200
+++ b/mercurial/localrepo.py	Mon May 17 15:24:46 2021 +0200
@@ -2754,13 +2754,18 @@
 
         unfi = self.unfiltered()
 
-        if caches is None:
-            if full:
-                caches = repository.CACHES_ALL
-                if full == b"post-clone":
-                    caches = repository.CACHES_POST_CLONE
-            else:
-                caches = repository.CACHES_DEFAULT
+        if full:
+            msg = (
+                "`full` argument for `repo.updatecaches` is deprecated\n"
+                "(use `caches=repository.CACHE_ALL` instead)"
+            )
+            self.ui.deprecwarn(msg, "5.9")
+            caches = repository.CACHES_ALL
+            if full == b"post-clone":
+                caches = repository.CACHES_POST_CLONE
+            caches = repository.CACHES_ALL
+        elif caches is None:
+            caches = repository.CACHES_DEFAULT
 
         if repository.CACHE_BRANCHMAP_SERVED in caches:
             if tr is None or tr.changes[b'origrepolen'] < len(self):