# HG changeset patch # User Yuya Nishihara # Date 1505746145 -32400 # Node ID 8c3dd5e462cc39ea2fed1c577da079953d4e6b38 # Parent 4c1cfe54c08ddfef0f1db9ab7ffbab109b93f9e6 templatekw: fix scope of peerpath url bound to generator I had to explicitly bind 'd' to the generator. Otherwise, the last 'd' would be used. diff -r 4c1cfe54c08d -r 8c3dd5e462cc mercurial/templatekw.py --- a/mercurial/templatekw.py Mon Sep 18 23:07:17 2017 +0900 +++ b/mercurial/templatekw.py Mon Sep 18 23:49:05 2017 +0900 @@ -663,9 +663,9 @@ d = util.sortdict() d['url'] = p.rawloc d.update((o, v) for o, v in sorted(p.suboptions.iteritems())) - def f(): + def f(d): yield d['url'] - paths[k] = hybriddict(d, gen=f()) + paths[k] = hybriddict(d, gen=f(d)) # no hybriddict() since d['path'] can't be formatted as a string. perhaps # hybriddict() should call templatefilters.stringify(d[value]). diff -r 4c1cfe54c08d -r 8c3dd5e462cc tests/test-paths.t --- a/tests/test-paths.t Mon Sep 18 23:07:17 2017 +0900 +++ b/tests/test-paths.t Mon Sep 18 23:49:05 2017 +0900 @@ -94,10 +94,10 @@ dupe=$TESTTMP/b#tip (glob) expand=$TESTTMP/a/$SOMETHING/bar (glob) $ hg log -rnull -T '{peerpaths % "{name}: {path}\n"}' - dupe: $TESTTMP/a/$SOMETHING/bar (glob) + dupe: $TESTTMP/b#tip (glob) expand: $TESTTMP/a/$SOMETHING/bar (glob) $ hg log -rnull -T '{get(peerpaths, "dupe")}\n' - $TESTTMP/a/$SOMETHING/bar (glob) + $TESTTMP/b#tip (glob) (but a path is actually a dict of url and sub-options)