# HG changeset patch # User Mathias De Mare # Date 1547208865 -3600 # Node ID 92b3811fd15f0a9d0f795e85dec520a5f5c3ee15 # Parent f3f5bfbf7e041f88d7db4f258b4f54319fefc2bd hg-docker: fix Python 3.4 compatibility (for CentOS 7) I realize Mercurial is not targetting Python 3.4 compatibility, but without this change, it's not even possible to build it on CentOS 7 (and I assume the same is true for RHEL 7). Differential Revision: https://phab.mercurial-scm.org/D5570 diff -r f3f5bfbf7e04 -r 92b3811fd15f contrib/packaging/hg-docker --- a/contrib/packaging/hg-docker Tue Jan 15 11:07:34 2019 -0800 +++ b/contrib/packaging/hg-docker Fri Jan 11 13:14:25 2019 +0100 @@ -72,7 +72,12 @@ ] print('executing: %r' % args) - subprocess.run(args, input=dockerfile, check=True) + p = subprocess.Popen(args, stdin=subprocess.PIPE) + p.communicate(input=dockerfile) + if p.returncode: + raise subprocess.CalledProcessException( + p.returncode, 'failed to build docker image: %s %s' \ + % (p.stdout, p.stderr)) def command_build(args): build_args = []