# HG changeset patch # User Matt Mackall # Date 1245384513 18000 # Node ID 980f5b7c5fb61fc2f67935513849c37c2fe94405 # Parent e28b7939d43064e8304c901e0d196e0939cba637 tags: drop nested function diff -r e28b7939d430 -r 980f5b7c5fb6 mercurial/localrepo.py --- a/mercurial/localrepo.py Thu Jun 18 23:04:54 2009 -0500 +++ b/mercurial/localrepo.py Thu Jun 18 23:08:33 2009 -0500 @@ -290,26 +290,24 @@ globaltags[k] = an, ah tagtypes[k] = tagtype - def tagctxs(): - seen = set() - f = None - ret = [] - for node in self.heads(): - try: - fnode = self[node].filenode('.hgtags') - except error.LookupError: - continue - if fnode not in seen: - seen.add(fnode) - if not f: - f = self.filectx('.hgtags', fileid=fnode) - else: - f = f.filectx(fnode) - ret.append(f) - return reversed(ret) + seen = set() + f = None + ctxs = [] + for node in self.heads(): + try: + fnode = self[node].filenode('.hgtags') + except error.LookupError: + continue + if fnode not in seen: + seen.add(fnode) + if not f: + f = self.filectx('.hgtags', fileid=fnode) + else: + f = f.filectx(fnode) + ctxs.append(f) # read the tags file from each head, ending with the tip - for f in tagctxs(): + for f in reversed(ctxs): readtags(f.data().splitlines(), f, "global") try: