# HG changeset patch # User Simon Heimberg # Date 1247573107 -7200 # Node ID 996c1cd8f53068ce88e77414a5d3dc7ead419c3c # Parent b47d7b440c5c4bc9c2cc40576f42a95b1c69eb70 store: eliminate reference cycle in fncachestore no reference to self in fncacheopener Inspired by Adrian Buehlmann diff -r b47d7b440c5c -r 996c1cd8f530 mercurial/store.py --- a/mercurial/store.py Fri Jul 10 19:34:08 2009 +0900 +++ b/mercurial/store.py Tue Jul 14 14:05:07 2009 +0200 @@ -284,16 +284,17 @@ self.pathjoiner = pathjoiner self.path = self.pathjoiner(path, 'store') self.createmode = _calcmode(self.path) - self._op = opener(self.path) - self._op.createmode = self.createmode - self.fncache = fncache(self._op) + op = opener(self.path) + op.createmode = self.createmode + fnc = fncache(op) + self.fncache = fnc def fncacheopener(path, mode='r', *args, **kw): if (mode not in ('r', 'rb') and path.startswith('data/') - and path not in self.fncache): - self.fncache.add(path) - return self._op(hybridencode(path), mode, *args, **kw) + and path not in fnc): + fnc.add(path) + return op(hybridencode(path), mode, *args, **kw) self.opener = fncacheopener def join(self, f):