# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1546066262 18000
# Node ID 9d35ae3d9999a915f701386e9e2ac7976abf5000
# Parent  88d813cd9acd56490fdac2c0b8e66c5231c63d88
phabricator: ensure that the return of urlopener.open() is closed

No problem observed, just an oversight noticed while reading documentation.

diff -r 88d813cd9acd -r 9d35ae3d9999 hgext/phabricator.py
--- a/hgext/phabricator.py	Thu Dec 20 09:59:16 2018 +0100
+++ b/hgext/phabricator.py	Sat Dec 29 01:51:02 2018 -0500
@@ -41,6 +41,7 @@
 
 from __future__ import absolute_import
 
+import contextlib
 import itertools
 import json
 import operator
@@ -214,7 +215,8 @@
     else:
         urlopener = urlmod.opener(repo.ui, authinfo)
         request = util.urlreq.request(url, data=data)
-        body = urlopener.open(request).read()
+        with contextlib.closing(urlopener.open(request)) as rsp:
+            body = rsp.read()
     repo.ui.debug(b'Conduit Response: %s\n' % body)
     parsed = json.loads(body)
     if parsed.get(r'error_code'):