# HG changeset patch # User Yuya Nishihara # Date 1599895141 -32400 # Node ID a717de1cb624e8aee32dac7c388ecc1cc891e508 # Parent 142f0dcf90d068948edbe1c94fe897667fb7f610 log: remove unused argument from _makerevset() I want to make getrevs() reusable for other commands, but the dependency graph of this getrevs() function is a mess. Let's minimize it first. diff -r 142f0dcf90d0 -r a717de1cb624 mercurial/logcmdutil.py --- a/mercurial/logcmdutil.py Sat Sep 12 16:11:10 2020 +0900 +++ b/mercurial/logcmdutil.py Sat Sep 12 16:19:01 2020 +0900 @@ -800,7 +800,7 @@ } -def _makerevset(repo, match, pats, slowpath, opts): +def _makerevset(repo, pats, slowpath, opts): """Return a revset string built from log options and file patterns""" opts = dict(opts) # follow or not follow? @@ -896,7 +896,7 @@ def filematcher(ctx): return match - expr = _makerevset(repo, match, pats, slowpath, opts) + expr = _makerevset(repo, pats, slowpath, opts) if opts.get(b'graph'): if repo.ui.configbool(b'experimental', b'log.topo'): if not revs.istopo(): diff -r 142f0dcf90d0 -r a717de1cb624 tests/printrevset.py --- a/tests/printrevset.py Sat Sep 12 16:11:10 2020 +0900 +++ b/tests/printrevset.py Sat Sep 12 16:19:01 2020 +0900 @@ -16,7 +16,7 @@ if not revs: return None match, pats, slowpath = logcmdutil._makematcher(repo, revs, pats, opts) - return logcmdutil._makerevset(repo, match, pats, slowpath, opts) + return logcmdutil._makerevset(repo, pats, slowpath, opts) def uisetup(ui):