# HG changeset patch
# User Patrick Mezard <pmezard@gmail.com>
# Date 1189801073 -7200
# Node ID a76c61679b71233dfb38305ef715bc5533d783c1
# Parent  961876838de0c2bcd7678cae909a901f4bdaa22a
convert: call popen2 in binary mode, with a command string.

diff -r 961876838de0 -r a76c61679b71 hgext/convert/cvs.py
--- a/hgext/convert/cvs.py	Fri Sep 14 22:17:53 2007 +0200
+++ b/hgext/convert/cvs.py	Fri Sep 14 22:17:53 2007 +0200
@@ -163,7 +163,10 @@
                 else:
                     cmd = [rsh, host] + cmd
 
-            self.writep, self.readp = os.popen2(cmd)
+            # popen2 does not support argument lists under Windows
+            cmd = [util.shellquote(arg) for arg in cmd]
+            cmd = util.quotecommand(' '.join(cmd))
+            self.writep, self.readp = os.popen2(cmd, 'b')
 
         self.realroot = root