# HG changeset patch # User Matt Harbison # Date 1540002707 14400 # Node ID a9e303dcd1e1f22e9930fe745aee21674cf209c0 # Parent bd1ec1e36bf06e8c70029c7e58266eb98ae74166 py3: stringify setupversion on Windows This was stringified a few lines above for non Windows platforms, but `version` remains bytes. The old code effectively undid the conversion, and triggered a warning in setuptools when building. diff -r bd1ec1e36bf0 -r a9e303dcd1e1 setup.py --- a/setup.py Fri Oct 19 23:47:38 2018 -0400 +++ b/setup.py Fri Oct 19 22:31:47 2018 -0400 @@ -1063,7 +1063,7 @@ if os.name == 'nt': # Windows binary file versions for exe/dll files must have the # form W.X.Y.Z, where W,X,Y,Z are numbers in the range 0..65535 - setupversion = version.split(b'+', 1)[0] + setupversion = setupversion.split(r'+', 1)[0] if sys.platform == 'darwin' and os.path.exists('/usr/bin/xcodebuild'): version = runcmd(['/usr/bin/xcodebuild', '-version'], {})[1].splitlines()