# HG changeset patch # User Pierre-Yves David # Date 1407196719 25200 # Node ID b36c60cfe46f9db4d1237ac94a93f80562e1a800 # Parent ecdff28d13e254c3802b0be863c3e38f869d9952 merge-tools: make premerge valid values extensible We want to introduce a version leaving merge3 style markers. diff -r ecdff28d13e2 -r b36c60cfe46f mercurial/filemerge.py --- a/mercurial/filemerge.py Mon Aug 04 16:50:15 2014 -0700 +++ b/mercurial/filemerge.py Mon Aug 04 16:58:39 2014 -0700 @@ -178,14 +178,15 @@ ui = repo.ui + validkeep = ['keep'] + # do we attempt to simplemerge first? try: premerge = _toolbool(ui, tool, "premerge", not binary) except error.ConfigError: premerge = _toolstr(ui, tool, "premerge").lower() - valid = 'keep'.split() - if premerge not in valid: - _valid = ', '.join(["'" + v + "'" for v in valid]) + if premerge not in validkeep: + _valid = ', '.join(["'" + v + "'" for v in validkeep]) raise error.ConfigError(_("%s.premerge not valid " "('%s' is neither boolean nor %s)") % (tool, premerge, _valid)) @@ -195,7 +196,7 @@ if not r: ui.debug(" premerge successful\n") return 0 - if premerge != 'keep': + if premerge not in validkeep: util.copyfile(back, a) # restore from backup and try again return 1 # continue merging