# HG changeset patch # User Boris Feld # Date 1534580697 -7200 # Node ID bd63ada7e1f838d7a579edcbd8e3c8ff7ec46a43 # Parent d8ac2ad55d9c6c0a50eb5d74ce1ddb28dcc55a2d phases: drop dead code in `newheads` There are new code earlier in the function achieving the same result. Spotted by Yuya Nishihara. diff -r d8ac2ad55d9c -r bd63ada7e1f8 mercurial/phases.py --- a/mercurial/phases.py Sat Aug 18 10:24:16 2018 +0200 +++ b/mercurial/phases.py Sat Aug 18 10:24:57 2018 +0200 @@ -678,8 +678,6 @@ # The logic operated on revisions, convert arguments early for convenience new_heads = set(rev(n) for n in heads if n != nullid) roots = [rev(n) for n in roots] - if not heads or not roots: - return heads # compute the area we need to remove affected_zone = repo.revs("(%ld::%ld)", roots, new_heads) # heads in the area are no longer heads