# HG changeset patch # User Martin von Zweigbergk # Date 1552322136 25200 # Node ID bf72e4c39f0bed8f4a477a295dc761c7c47da1a3 # Parent 481259af4bdfcfb1ad84cf0803626cb26aeb3514 uncommit: convert _fixdirstate() into _movedirstate() _fixdirstate() already also updates to the given commit, so let's rename it to _movedirstate(). Also update the documentation and drop the unnecessary "curctx" argument, since that should always be repo['.']. Differential Revision: https://phab.mercurial-scm.org/D6117 diff -r 481259af4bdf -r bf72e4c39f0b hgext/uncommit.py --- a/hgext/uncommit.py Mon Mar 11 02:34:12 2019 +0100 +++ b/hgext/uncommit.py Mon Mar 11 09:35:36 2019 -0700 @@ -99,10 +99,9 @@ extra=ctx.extra()) return repo.commitctx(new) -def _fixdirstate(repo, oldctx, newctx, match=None): - """ fix the dirstate after switching the working directory from oldctx to - newctx which can be result of either unamend or uncommit. - """ +def _movedirstate(repo, newctx, match=None): + """Move the dirstate to newctx and adjust it as necessary.""" + oldctx = repo['.'] ds = repo.dirstate ds.setparents(newctx.node(), node.nullid) copies = dict(ds.copies()) @@ -194,7 +193,7 @@ mapping[old.node()] = () with repo.dirstate.parentchange(): - _fixdirstate(repo, old, repo[newid], match) + _movedirstate(repo, repo[newid], match) scmutil.cleanupnodes(repo, mapping, 'uncommit', fixphase=True) @@ -256,7 +255,7 @@ dirstate = repo.dirstate with dirstate.parentchange(): - _fixdirstate(repo, curctx, newpredctx) + _movedirstate(repo, newpredctx) mapping = {curctx.node(): (newprednode,)} scmutil.cleanupnodes(repo, mapping, 'unamend', fixphase=True)