# HG changeset patch # User Manuel Jacob # Date 1593650775 -7200 # Node ID c05ac059749f670114eda3e8de60e790885836b6 # Parent 3862de62d5cf0a7152d77b4de2aa0b0252a18474 cleanup: use any() instead of checking truthiness of temporary list It was not immediately obvious to me, when first seeing this, why a list was created. It needed a second look to understand that the purpose was to check whether the condition is true for any of the parents. Using any() for that is clearer. diff -r 3862de62d5cf -r c05ac059749f mercurial/cmdutil.py --- a/mercurial/cmdutil.py Fri Jul 03 13:45:59 2020 +0530 +++ b/mercurial/cmdutil.py Thu Jul 02 02:46:15 2020 +0200 @@ -3437,9 +3437,9 @@ not opts.get(b'amend') and bheads and node not in bheads - and not [ - x for x in parents if x.node() in bheads and x.branch() == branch - ] + and not any( + x.node() in bheads and x.branch() == branch for x in parents + ) ): repo.ui.status(_(b'created new head\n')) # The message is not printed for initial roots. For the other