# HG changeset patch # User Gregory Szorc # Date 1490161577 25200 # Node ID c0c4e14ee59702e8fa1c872e22cb70a6a4754672 # Parent b2a41a826d71b11b949c51695b3730746bed0c94 check-code: recommend util.urlreq when importing urlparse diff -r b2a41a826d71 -r c0c4e14ee597 contrib/check-code.py --- a/contrib/check-code.py Tue Mar 21 22:45:02 2017 -0700 +++ b/contrib/check-code.py Tue Mar 21 22:46:17 2017 -0700 @@ -330,7 +330,7 @@ (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"), (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"), (r'^import SocketServer', "don't use SockerServer, use util.socketserver"), - (r'^import urlparse', "don't use urlparse, use util.urlparse"), + (r'^import urlparse', "don't use urlparse, use util.urlreq"), (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), (r'^import cPickle', "don't use cPickle, use util.pickle"), (r'^import pickle', "don't use pickle, use util.pickle"),