# HG changeset patch # User Augie Fackler # Date 1536179371 14400 # Node ID c68cfc55af9d1d210b373fbf8eac41f402759e55 # Parent 094d1f42c484bb43b68e073bd49897a31c48b978 buildrpm: fix embarassing bug in shell variable expansions `$distance_$node` looks up and concatenates `$distance_` and `$node`. `$distance_` is empty, so we were getting the node without the distance. Using the curly braces makes our intent explicit and produces better-versioned RPMS. Differential Revision: https://phab.mercurial-scm.org/D4493 diff -r 094d1f42c484 -r c68cfc55af9d contrib/packaging/buildrpm --- a/contrib/packaging/buildrpm Wed Sep 05 21:49:44 2018 +0900 +++ b/contrib/packaging/buildrpm Wed Sep 05 16:29:31 2018 -0400 @@ -59,7 +59,7 @@ fi if [ -n "$distance" ] ; then - release=$release+$distance_$node + release=$release+${distance}_${node} fi if [ "$PYTHONVER" ]; then