# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1494871682 14400
# Node ID ca727147ff9feb8fe6f27e0e4c46eff605574d7b
# Parent  0ad0d26ff703e1a0dd3dd5aa410f256b04082463
style: ban [ foo == bar] bashism in tests

diff -r 0ad0d26ff703 -r ca727147ff9f contrib/check-code.py
--- a/contrib/check-code.py	Sat May 13 16:26:43 2017 -0700
+++ b/contrib/check-code.py	Mon May 15 14:08:02 2017 -0400
@@ -116,6 +116,7 @@
     (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),
     (r'\$\(.*\)', "don't use $(expr), use `expr`"),
     (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
+    (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),
     (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
      "use egrep for extended grep syntax"),
     (r'/bin/', "don't use explicit paths for tools"),
diff -r 0ad0d26ff703 -r ca727147ff9f tests/test-contrib-check-code.t
--- a/tests/test-contrib-check-code.t	Sat May 13 16:26:43 2017 -0700
+++ b/tests/test-contrib-check-code.t	Mon May 15 14:08:02 2017 -0400
@@ -152,6 +152,15 @@
    >   $ function onwarn {}
    warning: don't use 'function', use old style
   [1]
+  $ cat > error.t <<EOF
+  >   $ [ foo == bar ]
+  > EOF
+  $ "$check_code" error.t
+  error.t:1:
+   >   $ [ foo == bar ]
+   [ foo == bar ] is a bashism, use [ foo = bar ] instead
+  [1]
+  $ rm error.t
   $ cat > raise-format.py <<EOF
   > raise SomeException, message
   > # this next line is okay