# HG changeset patch # User Boris Feld # Date 1529622442 -3600 # Node ID cc3543c87de5266f63a6c3d4d3488f1c8e9d3a5b # Parent 6db38c9d7e0057fb2c29e95b048253a9a0ed163f revlog: reuse 'descendant' implemention in 'isancestor' The two functions do the same thing, but one takes nodes while the other takes revs. Using one to implement the other make sense. We should probably cleanup the API at some point to avoid having so many similar functions. However, we focus on an efficient implementation for now. diff -r 6db38c9d7e00 -r cc3543c87de5 mercurial/revlog.py --- a/mercurial/revlog.py Fri Jun 22 00:05:20 2018 +0100 +++ b/mercurial/revlog.py Fri Jun 22 00:07:22 2018 +0100 @@ -1404,7 +1404,8 @@ The implementation of this is trivial but the use of commonancestorsheads is not.""" - return a in self.commonancestorsheads(a, b) + a, b = self.rev(a), self.rev(b) + return self.descendant(a, b) def ancestor(self, a, b): """calculate the "best" common ancestor of nodes a and b"""