# HG changeset patch # User Boris Feld # Date 1520609495 -3600 # Node ID cc51b6a07869876e6ad2e1aa0337e2e4b4da4f9e # Parent a2baa61bbb140f39b1392c7efa638abff95500a8 push-discovery: don't turn use generator when comparing bookmarks We want extensions to be able to implement their own logic. Generators can be consume only once, impractical for this purpose. diff -r a2baa61bbb14 -r cc51b6a07869 mercurial/exchange.py --- a/mercurial/exchange.py Tue Mar 13 16:56:13 2018 -0700 +++ b/mercurial/exchange.py Fri Mar 09 16:31:35 2018 +0100 @@ -620,8 +620,8 @@ return hex(x) def hexifycompbookmarks(bookmarks): - for b, scid, dcid in bookmarks: - yield b, safehex(scid), safehex(dcid) + return [(b, safehex(scid), safehex(dcid)) + for (b, scid, dcid) in bookmarks] comp = [hexifycompbookmarks(marks) for marks in comp] addsrc, adddst, advsrc, advdst, diverge, differ, invalid, same = comp