# HG changeset patch # User Gregory Szorc # Date 1479787971 28800 # Node ID d1b97fc87f551ac0b4359015bf57f9cfabca5c35 # Parent 8491845a75b250347f796f3dd966a8707c8d72b2 httppeer: document why super() isn't used Adding a follow-up to document lack of super() per Augie's request. diff -r 8491845a75b2 -r d1b97fc87f55 mercurial/httppeer.py --- a/mercurial/httppeer.py Thu Nov 17 00:59:41 2016 -0800 +++ b/mercurial/httppeer.py Mon Nov 21 20:12:51 2016 -0800 @@ -39,6 +39,9 @@ # We need to wrap reader.read() so HTTPException on subsequent # reads is also converted. + # Ideally we'd use super() here. However, if ``reader`` isn't a new-style + # class, this can raise: + # TypeError: super() argument 1 must be type, not classobj origread = reader.read class readerproxy(reader.__class__): def read(self, *args, **kwargs):