# HG changeset patch # User Pulkit Goyal <7895pulkit@gmail.com> # Date 1594108453 -19800 # Node ID d23881b17388aa254bacef31e6f81ff563b597fb # Parent da2e69a278df886ebe5eee3488b41cf69c6274c8 extdiff: remove unrequired do3way argument to diffpatch() When we are diffing patches, there is no 3 way diff. Differential Revision: https://phab.mercurial-scm.org/D8688 diff -r da2e69a278df -r d23881b17388 hgext/extdiff.py --- a/hgext/extdiff.py Tue Jul 07 13:13:18 2020 +0530 +++ b/hgext/extdiff.py Tue Jul 07 13:24:13 2020 +0530 @@ -350,7 +350,7 @@ proc.wait() -def diffpatch(ui, repo, node1a, node2, tmproot, matcher, cmdline, do3way): +def diffpatch(ui, repo, node1a, node2, tmproot, matcher, cmdline): template = b'hg-%h.patch' with formatter.nullformatter(ui, b'extdiff', {}) as fm: cmdutil.export( @@ -369,12 +369,13 @@ cmdline = formatcmdline( cmdline, repo.root, - do3way=do3way, parent1=dir1a, plabel1=label1a, parent2=dir1b, plabel2=label1b, child=dir2, + # no 3way while comparing patches + do3way=False, clabel=label2, ) ui.debug(b'running %r in %s\n' % (pycompat.bytestr(cmdline), tmproot)) @@ -567,9 +568,7 @@ tmproot = pycompat.mkdtemp(prefix=b'extdiff.') try: if opts.get(b'patch'): - return diffpatch( - ui, repo, node1a, node2, tmproot, matcher, cmdline, do3way - ) + return diffpatch(ui, repo, node1a, node2, tmproot, matcher, cmdline) return diffrevs( ui,