# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1499454671 14400
# Node ID d36bcba91845b88aedbcc8ec7415dab500d56c63
# Parent  ffb30661f67288ac0797a899f753ffdda5738d98
check-code: prohibit `if False` antipattern

Differential Revision: https://phab.mercurial-scm.org/D20

diff -r ffb30661f672 -r d36bcba91845 contrib/check-code.py
--- a/contrib/check-code.py	Fri Jul 07 15:08:23 2017 -0400
+++ b/contrib/check-code.py	Fri Jul 07 15:11:11 2017 -0400
@@ -301,6 +301,7 @@
      "comparison with singleton, use 'is' or 'is not' instead"),
     (r'^\s*(while|if) [01]:',
      "use True/False for constant Boolean expression"),
+    (r'^\s*if False(:| +and)', 'Remove code instead of using `if False`'),
     (r'(?:(?<!def)\s+|\()hasattr\(',
      'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '
      'instead', r'#.*hasattr-py3-only'),