# HG changeset patch # User Anton Shestakov # Date 1510981247 -28800 # Node ID dd000a958364f44fd048e991e4f7eaba6121f7a7 # Parent 8db4ca76841674ab14974539116b454ddbc9500f check-code: grep's context flags don't need an extra space before number A bit of useless trivia found while researching this: OpenBSD's grep's -C has a default value (of 2) and disallows space before the argument (while -A and -B allow). diff -r 8db4ca768416 -r dd000a958364 contrib/check-code.py --- a/contrib/check-code.py Wed Nov 15 01:07:42 2017 -0800 +++ b/contrib/check-code.py Sat Nov 18 13:00:47 2017 +0800 @@ -148,7 +148,7 @@ (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), - (r'grep.* -[ABC] ', "don't use grep's context flags"), + (r'grep.* -[ABC]', "don't use grep's context flags"), ], # warnings [