# HG changeset patch # User Matt Harbison # Date 1424038908 18000 # Node ID e0f06228bb666c3950b5a1397e0db4cd50feb15a # Parent 9cb1f82a2571619776a92eb5b5a0028adc853969 archive: change the default prefix to '' from None All current callers supply some sort of prefix, so the issue was hidden. But if no parameter was specified, a crash occurred in the write() closure when concatenating 'prefix' and 'name'. diff -r 9cb1f82a2571 -r e0f06228bb66 hgext/largefiles/overrides.py --- a/hgext/largefiles/overrides.py Wed Feb 25 11:39:14 2015 -0800 +++ b/hgext/largefiles/overrides.py Sun Feb 15 17:21:48 2015 -0500 @@ -861,7 +861,7 @@ repo._lfcommithooks.pop() def overridearchive(orig, repo, dest, node, kind, decode=True, matchfn=None, - prefix=None, mtime=None, subrepos=None): + prefix='', mtime=None, subrepos=None): # No need to lock because we are only reading history and # largefile caches, neither of which are modified. lfcommands.cachelfiles(repo.ui, repo, node) diff -r 9cb1f82a2571 -r e0f06228bb66 mercurial/archival.py --- a/mercurial/archival.py Wed Feb 25 11:39:14 2015 -0800 +++ b/mercurial/archival.py Sun Feb 15 17:21:48 2015 -0500 @@ -230,7 +230,7 @@ } def archive(repo, dest, node, kind, decode=True, matchfn=None, - prefix=None, mtime=None, subrepos=False): + prefix='', mtime=None, subrepos=False): '''create archive of repo as it was at node. dest can be name of directory, name of archive file, or file