# HG changeset patch # User Gregory Szorc # Date 1497548183 25200 # Node ID e5a6a540ae630cd7d96953fc362642115493b25e # Parent 7c11869cf23a79883a86ce49c50246f328221ae1 check-config: use compiled regexp And split the regexp across multiple lines to make it easier to read. diff -r 7c11869cf23a -r e5a6a540ae63 contrib/check-config.py --- a/contrib/check-config.py Thu Jun 15 10:46:39 2017 -0700 +++ b/contrib/check-config.py Thu Jun 15 10:36:23 2017 -0700 @@ -14,8 +14,16 @@ foundopts = {} documented = {} -configre = (r"""ui\.config(|int|bool|list)\(['"](\S+)['"],\s*""" - r"""['"](\S+)['"](,\s+(?:default=)?(\S+?))?\)""") +configre = re.compile(r''' + # Function call + ui\.config(|int|bool|list)\( + # First argument. + ['"](\S+)['"],\s* + # Second argument + ['"](\S+)['"](,\s+ + (?:default=)?(\S+?))? + \)''', re.VERBOSE | re.MULTILINE) + configpartialre = (r"""ui\.config""") def main(args): @@ -71,7 +79,7 @@ # look for code-like bits line = carryover + l - m = re.search(configre, line, re.MULTILINE) + m = configre.search(line) if m: ctype = m.group(1) if not ctype: