# HG changeset patch # User Pulkit Goyal <7895pulkit@gmail.com> # Date 1495398823 -19800 # Node ID e72c5263ccaf2754f4c5d170f82829a8881b3144 # Parent 14482f8e6ce65de1c6ab73820ece5cd5863e9a98 revset: use try-except instead of if-else because of perf For wdir(), we now raises an exception which will be raised when wdir() will be passed, so catching that exception is better checking for wdir() using if-else. diff -r 14482f8e6ce6 -r e72c5263ccaf mercurial/revset.py --- a/mercurial/revset.py Mon May 22 01:38:00 2017 +0530 +++ b/mercurial/revset.py Mon May 22 02:03:43 2017 +0530 @@ -1456,10 +1456,10 @@ up = ps.update parentrevs = cl.parentrevs for r in getset(repo, fullreposet(repo), x): - if r == node.wdirrev: + try: + up(parentrevs(r)) + except error.WdirUnsupported: up(p.rev() for p in repo[r].parents()) - else: - up(parentrevs(r)) ps -= {node.nullrev} return subset & ps