# HG changeset patch # User Dan Villiom Podlaski Christiansen # Date 1289939758 -3600 # Node ID ea68947ad0ce9ced3d62f716ebb75c6a95877a39 # Parent 417f3c27983bcb6ab95b169801edc63c5c138dcf httprepo: remove is-comparison with string literal An identity check between a variable and a string literal was added to the pushkey implementation in 6bd9778ae749. While CPython will normally intern strings and thus make the test safe, value identity is what should be used here. diff -r 417f3c27983b -r ea68947ad0ce mercurial/httprepo.py --- a/mercurial/httprepo.py Mon Nov 15 17:04:55 2010 -0600 +++ b/mercurial/httprepo.py Tue Nov 16 21:35:58 2010 +0100 @@ -68,7 +68,7 @@ raise util.Abort(_('operation not supported over http')) def _callstream(self, cmd, **args): - if cmd is 'pushkey': + if cmd == 'pushkey': args['data'] = '' data = args.pop('data', None) headers = args.pop('headers', {})