# HG changeset patch # User Bryan O'Sullivan # Date 1247097678 25200 # Node ID ec171737aaf1c03f39c96eb6dd878c60242d31e5 # Parent fce065538bcf858c00731fd2ca77ba631553fdd9 Backed out changeset fce065538bcf: it caused a 5x performance regression on OS X diff -r fce065538bcf -r ec171737aaf1 mercurial/util.py --- a/mercurial/util.py Sat May 09 17:34:11 2009 +0200 +++ b/mercurial/util.py Wed Jul 08 17:01:18 2009 -0700 @@ -38,12 +38,14 @@ import subprocess closefds = os.name == 'posix' -def popen2(cmd): - p = subprocess.Popen(cmd, shell=True, close_fds=closefds, +def popen2(cmd, bufsize=-1): + p = subprocess.Popen(cmd, shell=True, bufsize=bufsize, + close_fds=closefds, stdin=subprocess.PIPE, stdout=subprocess.PIPE) return p.stdin, p.stdout -def popen3(cmd): - p = subprocess.Popen(cmd, shell=True, close_fds=closefds, +def popen3(cmd, bufsize=-1): + p = subprocess.Popen(cmd, shell=True, bufsize=bufsize, + close_fds=closefds, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE) return p.stdin, p.stdout, p.stderr