# HG changeset patch # User Pierre-Yves David # Date 1675355857 -3600 # Node ID f013e790d8bf10defe4cc2fe6458887ff9c0f56c # Parent 832df74a488f8d853483b14eff67bdb796ea8d12 safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff -r 832df74a488f -r f013e790d8bf mercurial/templateutil.py --- a/mercurial/templateutil.py Thu Feb 02 17:37:31 2023 +0100 +++ b/mercurial/templateutil.py Thu Feb 02 17:37:37 2023 +0100 @@ -307,7 +307,7 @@ return hybriditem(None, key, val, self._makemap) def filter(self, context, mapping, select): - if util.safehasattr(self._values, b'get'): + if util.safehasattr(self._values, 'get'): values = { k: v for k, v in self._values.items()