# HG changeset patch # User Matt Mackall # Date 1297367188 21600 # Node ID f1c5294e9119adbd33257afa5d6cb0cf93801f2c # Parent ddddb76f2da3e9b83ff638f42b844780245d2d0e bookmarks: merge suspect addchangegroup into core This is marked with FIXME because it's not clear that it makes any sense. diff -r ddddb76f2da3 -r f1c5294e9119 hgext/bookmarks.py --- a/hgext/bookmarks.py Thu Feb 10 13:46:28 2011 -0600 +++ b/hgext/bookmarks.py Thu Feb 10 13:46:28 2011 -0600 @@ -129,23 +129,6 @@ label=label) return -def reposetup(ui, repo): - if not repo.local(): - return - - class bookmark_repo(repo.__class__): - def addchangegroup(self, *args, **kwargs): - result = super(bookmark_repo, self).addchangegroup(*args, **kwargs) - if result > 1: - # We have more heads than before - return result - node = self.changelog.tip() - parents = self.dirstate.parents() - bookmarks.update(self, parents, node) - return result - - repo.__class__ = bookmark_repo - def pull(oldpull, ui, repo, source="default", **opts): # translate bookmark args to rev args for actual pull if opts.get('bookmark'): diff -r ddddb76f2da3 -r f1c5294e9119 mercurial/localrepo.py --- a/mercurial/localrepo.py Thu Feb 10 13:46:28 2011 -0600 +++ b/mercurial/localrepo.py Thu Feb 10 13:46:28 2011 -0600 @@ -1891,6 +1891,10 @@ self.hook("incoming", node=hex(cl.node(i)), source=srctype, url=url) + # FIXME - why does this care about tip? + if newheads == oldheads: + bookmarks.update(self, self.dirstate.parents(), self['tip'].node()) + # never return 0 here: if newheads < oldheads: return newheads - oldheads - 1