# HG changeset patch # User Gregory Szorc # Date 1458420660 25200 # Node ID f29cab5c519ca546b1796eb2a874367024795f01 # Parent b0b9f6b0a7773e200f264664af61795ccfc1c3c5 hghave: change ssl check to just check ssl module Previously, the "ssl" check effectively looked for PyOpenSSL or Python 2.7.9. After this patch, we simply look for just the "ssl" module. After d962e955da08, there have been no references to PyOpenSSL in the tree (the previous usage of PyOpenSSL was to implement ssl support on old, no longer supported Python versions that didn't have an ssl module (e.g. Python 2.4). So, the check for PyOpenSSL served no purpose. Pythons we support ship with the ssl module. Although it may not be available in all installations. So, we still need the check for whether the ssl module imports, hence the hghave check. The main side-effect of this change is that we now run test-https.t (the only test requiring the "ssl" hghave feature) on Python <2.7.9 when PyOpenSSL is not installed (which is probably most installations) and the ssl module is available. Before, we wouldn't run this test on these older Python versions. I confirmed that test-https.t passes with Python 2.6.9 and 2.7.8 on OS X 10.11. diff -r b0b9f6b0a777 -r f29cab5c519c tests/hghave.py --- a/tests/hghave.py Sat Mar 19 15:17:33 2016 -0700 +++ b/tests/hghave.py Sat Mar 19 13:51:00 2016 -0700 @@ -341,15 +341,11 @@ return not matchoutput('hg root 2>&1', r'abort: no repository found', True) -@check("ssl", ("(python >= 2.6 ssl module and python OpenSSL) " - "OR python >= 2.7.9 ssl")) +@check("ssl", "ssl module available") def has_ssl(): try: import ssl - if getattr(ssl, 'create_default_context', False): - return True - import OpenSSL - OpenSSL.SSL.Context + ssl.CERT_NONE return True except ImportError: return False