# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1582845446 -3600
# Node ID f6798c1a80fabeed813aeccf160a70c28619d730
# Parent  baf8c3f944eb9abe6ae349c2c085da04ad6ad804
transaction: clarify the logic around pre-finalize/post-finalize

I am taking a bit more verbose route, but I find it easier to follow for people
who (re)discover the code.

(This is a gratuitous cleanup I did while looking at something else.)

Differential Revision: https://phab.mercurial-scm.org/D8176

diff -r baf8c3f944eb -r f6798c1a80fa mercurial/transaction.py
--- a/mercurial/transaction.py	Fri Feb 28 00:02:03 2020 +0100
+++ b/mercurial/transaction.py	Fri Feb 28 00:17:26 2020 +0100
@@ -355,16 +355,22 @@
     def _generatefiles(self, suffix=b'', group=GEN_GROUP_ALL):
         # write files registered for generation
         any = False
+
+        if group == GEN_GROUP_ALL:
+            skip_post = skip_pre = False
+        else:
+            skip_pre = group == GEN_GROUP_POST_FINALIZE
+            skip_post = group == GEN_GROUP_PRE_FINALIZE
+
         for id, entry in sorted(pycompat.iteritems(self._filegenerators)):
             any = True
             order, filenames, genfunc, location = entry
 
             # for generation at closing, check if it's before or after finalize
-            postfinalize = group == GEN_GROUP_POST_FINALIZE
-            if (
-                group != GEN_GROUP_ALL
-                and (id in postfinalizegenerators) != postfinalize
-            ):
+            is_post = id in postfinalizegenerators
+            if skip_post and is_post:
+                continue
+            elif skip_pre and not is_post:
                 continue
 
             vfs = self._vfsmap[location]