# HG changeset patch # User Nicolas Dumazet # Date 1251110864 -7200 # Node ID f7968bba2307e25ba8d8731ca43e990b6e6ea0a3 # Parent d91078a2652f4f00cecb3092d05531e2d3987bf5 churn: issue833 was reintroduced in 9bc46d069a76, correct it and add a test diff -r d91078a2652f -r f7968bba2307 hgext/churn.py --- a/hgext/churn.py Sun Aug 23 11:32:44 2009 +0200 +++ b/hgext/churn.py Mon Aug 24 12:47:44 2009 +0200 @@ -146,7 +146,8 @@ sortfn = ((not opts.get('sort')) and (lambda a, b: cmp(b[1], a[1])) or None) rate.sort(sortfn) - maxcount = float(max([v for k, v in rate])) + # Be careful not to have a zero maxcount (issue833) + maxcount = float(max([v for k, v in rate])) or 1.0 maxname = max([len(k) for k, v in rate]) ttywidth = util.termwidth() diff -r d91078a2652f -r f7968bba2307 tests/test-churn --- a/tests/test-churn Sun Aug 23 11:32:44 2009 +0200 +++ b/tests/test-churn Mon Aug 24 12:47:44 2009 +0200 @@ -48,3 +48,13 @@ echo % churn by hour hg churn -f '%H' -s +cd .. + +# issue 833: ZeroDivisionError +hg init issue-833 +cd issue-833 +touch foo +hg ci -Am foo +# this was failing with a ZeroDivisionError +hg churn +cd .. diff -r d91078a2652f -r f7968bba2307 tests/test-churn.out --- a/tests/test-churn.out Sun Aug 23 11:32:44 2009 +0200 +++ b/tests/test-churn.out Mon Aug 24 12:47:44 2009 +0200 @@ -28,3 +28,5 @@ 09 2 ********************************* 12 4 ****************************************************************** 13 1 **************** +adding foo +test 0