# HG changeset patch
# User David Soria Parra <davidsp@fb.com>
# Date 1481694598 28800
# Node ID fa2d2c8ac3981d77eafe41aaa8bcbd7a36e8e024
# Parent  be520fe3a3e95edb4a8db75d424ed067cb5bf706
convert: don't use long list comprehensions

We are iterating over p4changes. Make the continue condition more clear
and easier to add new conditions in future patches, by removing the list
comprehension and move the condition into the existing for-loop.

diff -r be520fe3a3e9 -r fa2d2c8ac398 hgext/convert/p4.py
--- a/hgext/convert/p4.py	Thu Dec 15 11:00:18 2016 -0800
+++ b/hgext/convert/p4.py	Tue Dec 13 21:49:58 2016 -0800
@@ -126,14 +126,16 @@
 
         # handle revision limiting
         startrev = self.ui.config('convert', 'p4.startrev', default=0)
-        self.p4changes = [x for x in self.p4changes
-                          if ((not startrev or int(x) >= int(startrev)) and
-                              (not self.revs or int(x) <= int(self.revs[0])))]
 
         # now read the full changelists to get the list of file revisions
         ui.status(_('collecting p4 changelists\n'))
         lastid = None
         for change in self.p4changes:
+            if startrev and int(change) < int(startrev):
+                continue
+            if self.revs and int(change) > int(self.revs[0]):
+                continue
+
             cmd = "p4 -G describe -s %s" % change
             stdout = util.popen(cmd, mode='rb')
             d = marshal.load(stdout)