# HG changeset patch # User Matt Mackall # Date 1353873420 21600 # Node ID fbe43efe4a530281ecb5ebba5848f0598ffcf0c6 # Parent a08775ec89f21e12db4dd02f88390d615646cb6d check-code: move i18n check from warning to error diff -r a08775ec89f2 -r fbe43efe4a53 contrib/check-code.py --- a/contrib/check-code.py Sun Nov 25 13:53:47 2012 -0600 +++ b/contrib/check-code.py Sun Nov 25 13:57:00 2012 -0600 @@ -211,11 +211,11 @@ (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"), (r'^\s*except\s*:', "warning: naked except clause", r'#.*re-raises'), (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"), + (r'ui\.(status|progress|write|note|warn)\([\'\"]x', + "missing _() in ui message (use () to hide false-positives)"), ], # warnings [ - (r'ui\.(status|progress|write|note|warn)\([\'\"]x', - "warning: unwrapped ui message"), ] ]