Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
chgserver: narrow scope of chdir() to socket.bind()
authorYuya Nishihara <yuya@tcha.org>
Sat, 21 May 2016 16:42:59 +0900
changeset 29529 02de1dbd4f6e
parent 29528 9c3786713926
child 29530 3239e2fdd2e2
chgserver: narrow scope of chdir() to socket.bind() This helps extracting a utility function.
hgext/chgserver.py file | annotate | diff | comparison | revisions 
--- a/hgext/chgserver.py	Mon Jul 11 15:45:34 2016 +0200
+++ b/hgext/chgserver.py	Sat May 21 16:42:59 2016 +0900
@@ -587,13 +587,13 @@
             bakwdfd = os.open('.', os.O_DIRECTORY)
             os.chdir(dirname)
         self.socket.bind(basename)
-        self._socketstat = os.stat(basename)
-        # rename will replace the old socket file if exists atomically. the
-        # old server will detect ownership change and exit.
-        util.rename(basename, self.server_address)
         if bakwdfd:
             os.fchdir(bakwdfd)
             os.close(bakwdfd)
+        self._socketstat = os.stat(tempaddress)
+        # rename will replace the old socket file if exists atomically. the
+        # old server will detect ownership change and exit.
+        util.rename(tempaddress, self.server_address)
 
     def issocketowner(self):
         try:
Mercurial