Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
run-tests: use a context manager when looking for available ports
authorMatt Harbison <matt_harbison@yahoo.com>
Sun, 29 Nov 2020 19:17:35 +0530
changeset 45955 064449f9fdc2
parent 45954 a120d1c9c704
child 45956 40f79997e81f
run-tests: use a context manager when looking for available ports Differential Revision: https://phab.mercurial-scm.org/D9441 Differential Revision: https://phab.mercurial-scm.org/D9452
tests/run-tests.py file | annotate | diff | comparison | revisions 
--- a/tests/run-tests.py	Fri Nov 27 15:54:46 2020 -0500
+++ b/tests/run-tests.py	Sun Nov 29 19:17:35 2020 +0530
@@ -47,6 +47,7 @@
 
 import argparse
 import collections
+import contextlib
 import difflib
 import distutils.version as version
 import errno
@@ -255,9 +256,8 @@
     else:
         family = socket.AF_INET
     try:
-        s = socket.socket(family, socket.SOCK_STREAM)
-        s.bind(('localhost', port))
-        s.close()
+        with contextlib.closing(socket.socket(family, socket.SOCK_STREAM)) as s:
+            s.bind(('localhost', port))
         return True
     except socket.error as exc:
         if exc.errno not in (
Mercurial