test: explicitly "add" file before some commit in test-filecache.py
authorPierre-Yves David <pierre-yves.david@octobus.net>
Mon, 13 Feb 2023 19:46:39 +0100
changeset 49988 09367b3d23d8
parent 49987 1e6015ddf698
child 49989 93d72a7dd486
test: explicitly "add" file before some commit in test-filecache.py `hg commit -A` will revert the `hg addremove` step if the commit fails. However `hg rollback` currently does not. We are about to improve internal consistency around transaction and dirstate and the behavior of `hg rollback` will align on the other behavior in the process. Before doing so, we make sure the test is using a separate call to `hg add` to avoid the test scenario to be affected by that future change. note: the behavior change for `hg rollback` seems fine as it affect a niche usecase and `hg rollback` usage have been strongly discouraged for a while.
tests/test-filecache.py
--- a/tests/test-filecache.py	Mon Feb 13 17:42:10 2023 +0100
+++ b/tests/test-filecache.py	Mon Feb 13 19:46:39 2023 +0100
@@ -165,7 +165,7 @@
 
 def test_filecache_synced():
     # test old behavior that caused filecached properties to go out of sync
-    os.system('hg init && echo a >> a && hg ci -qAm.')
+    os.system('hg init && echo a >> a && hg add a && hg ci -qm.')
     repo = hg.repository(uimod.ui.load())
     # first rollback clears the filecache, but changelog to stays in __dict__
     repo.rollback()