Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: ban grep's context flags (-A/-B/-C) since they're not on Solaris
authorDanek Duvall <danek.duvall@oracle.com>
Tue, 06 Jun 2017 08:58:27 -0700
changeset 32696 0c09afdf5704
parent 32695 0841382d114a
child 32697 19b9fc40cc51
check-code: ban grep's context flags (-A/-B/-C) since they're not on Solaris
contrib/check-code.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Tue Jun 06 08:52:51 2017 +0200
+++ b/contrib/check-code.py	Tue Jun 06 08:58:27 2017 -0700
@@ -145,6 +145,7 @@
     (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
     (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
     (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
+    (r'grep.* -[ABC] ', "don't use grep's context flags"),
   ],
   # warnings
   [
Mercurial