Mercurial > hg
changeset 46997:106402245301 stable
mail: add a TODO about proper mbox locking
Per @nbjoerg in IRC, the mbox isn't locked correctly.
Differential Revision: https://phab.mercurial-scm.org/D10505
| author | Matt Harbison <matt_harbison@yahoo.com> |
|---|---|
| date | Tue, 20 Apr 2021 23:31:36 -0400 |
| parents | 8d2b62d716b0 |
| children | 65d18001cfbf |
| files | mercurial/mail.py |
| diffstat | 1 files changed, 1 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/mail.py Tue Apr 20 20:35:46 2021 +0200 +++ b/mercurial/mail.py Tue Apr 20 23:31:36 2021 -0400 @@ -220,6 +220,7 @@ def _mbox(mbox, sender, recipients, msg): '''write mails to mbox''' + # TODO: use python mbox library for proper locking with open(mbox, b'ab+') as fp: # Should be time.asctime(), but Windows prints 2-characters day # of month instead of one. Make them print the same thing.