changeset 29330:12c97985ddeb

check-code: make 'ls' pattern less invasive I got false positive at "--tls smtps --certificate ...".
author Yuya Nishihara <yuya@tcha.org>
date Tue, 31 May 2016 21:49:49 +0900
parents 60621cecc8c5
children 1e02d9576194
files contrib/check-code.py
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-code.py	Thu Jun 09 13:47:42 2016 -0500
+++ b/contrib/check-code.py	Tue May 31 21:49:49 2016 +0900
@@ -122,7 +122,7 @@
     (r'export .*=', "don't export and assign at once"),
     (r'^source\b', "don't use 'source', use '.'"),
     (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
-    (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
+    (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
     (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'^stop\(\)', "don't use 'stop' as a shell function name"),
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),