changeset 45563:142f0dcf90d0

log: remove stale comment about order of user revset _makerevset() no longer depends on the computed revs since ea3320015d54 "log: remove dead code to follow descendants if ascending revisions specified."
author Yuya Nishihara <yuya@tcha.org>
date Sat, 12 Sep 2020 16:11:10 +0900
parents b51167d70f5a
children a717de1cb624
files mercurial/logcmdutil.py
diffstat 1 files changed, 1 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/logcmdutil.py	Fri Sep 25 17:51:34 2020 +0200
+++ b/mercurial/logcmdutil.py	Sat Sep 12 16:11:10 2020 +0900
@@ -898,14 +898,13 @@
 
     expr = _makerevset(repo, match, pats, slowpath, opts)
     if opts.get(b'graph'):
-        # User-specified revs might be unsorted, but don't sort before
-        # _makerevset because it might depend on the order of revs
         if repo.ui.configbool(b'experimental', b'log.topo'):
             if not revs.istopo():
                 revs = dagop.toposort(revs, repo.changelog.parentrevs)
                 # TODO: try to iterate the set lazily
                 revs = revset.baseset(list(revs), istopo=True)
         elif not (revs.isdescending() or revs.istopo()):
+            # User-specified revs might be unsorted
             revs.sort(reverse=True)
     if expr:
         matcher = revset.match(None, expr)