Mercurial > hg

changeset 39435:1467b6c27ff9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
wireprotov2peer: add TODO about streaming responses This is a pretty big deficiency in the current implementation. We don't want to forget about this. Differential Revision: https://phab.mercurial-scm.org/D4435
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 22 Aug 2018 10:29:30 -0700
parents 4971c9724206
children 3fe028b657bf
files mercurial/wireprotov2peer.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/wireprotov2peer.py	Tue Sep 04 12:36:33 2018 -0400
+++ b/mercurial/wireprotov2peer.py	Wed Aug 22 10:29:30 2018 -0700
@@ -136,6 +136,9 @@
         response = self._responses[frame.requestid]
 
         if action == 'responsedata':
+            # This buffers all data until end of stream is received. This
+            # is bad for performance.
+            # TODO make response data streamable
             response.b.write(meta['data'])
 
             if meta['eos']: