changeset 28435:176736afa886

wireproto: document quirk of _callstream between http and ssh This tripped me up when trying to use it, so it feels like we should document this to avoid future pain.
author Augie Fackler <augie@google.com>
date Wed, 02 Mar 2016 14:18:43 -0500
parents d549cbb5503d
children 8d38eab2777a
files mercurial/wireproto.py
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/wireproto.py	Tue Mar 01 16:37:56 2016 -0500
+++ b/mercurial/wireproto.py	Wed Mar 02 14:18:43 2016 -0500
@@ -396,9 +396,12 @@
     def _callstream(self, cmd, **args):
         """execute <cmd> on the server
 
-        The command is expected to return a stream.
+        The command is expected to return a stream. Note that if the
+        command doesn't return a stream, _callstream behaves
+        differently for ssh and http peers.
 
-        returns the server reply as a file like object."""
+        returns the server reply as a file like object.
+        """
         raise NotImplementedError()
 
     def _callcompressable(self, cmd, **args):