match: remove a mutable default argument
authorPierre-Yves David <pierre-yves.david@fb.com>
Thu, 24 Sep 2015 01:00:43 -0700
changeset 26328 188c1e9506f5
parent 26327 c786dd6cae57
child 26329 d9537ce64f3a
match: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs. We added support for None in the underlying function in the parent commit. therefore we do not need to do anything but passing None.
mercurial/scmutil.py
--- a/mercurial/scmutil.py	Thu Sep 24 01:00:25 2015 -0700
+++ b/mercurial/scmutil.py	Thu Sep 24 01:00:43 2015 -0700
@@ -778,7 +778,8 @@
         pats = []
     return m, pats
 
-def match(ctx, pats=(), opts={}, globbed=False, default='relpath', badfn=None):
+def match(ctx, pats=(), opts=None, globbed=False, default='relpath',
+          badfn=None):
     '''Return a matcher that will warn about bad matches.'''
     return matchandpats(ctx, pats, opts, globbed, default, badfn=badfn)[0]