py3: make sure we open files in bytes mode
authorPulkit Goyal <7895pulkit@gmail.com>
Sat, 19 May 2018 18:47:20 +0530
changeset 38082 1978abdb216c
parent 38081 8fa2b5c85a46
child 38083 5f2dc1b71cf1
py3: make sure we open files in bytes mode we internally deal with bytes and should read files in bytes mode. Differential Revision: https://phab.mercurial-scm.org/D3606
hgext/churn.py
mercurial/crecord.py
--- a/hgext/churn.py	Sat May 19 18:45:53 2018 +0530
+++ b/hgext/churn.py	Sat May 19 18:47:20 2018 +0530
@@ -161,7 +161,7 @@
     if not aliases and os.path.exists(repo.wjoin('.hgchurn')):
         aliases = repo.wjoin('.hgchurn')
     if aliases:
-        for l in open(aliases, "r"):
+        for l in open(aliases, "rb"):
             try:
                 alias, actual = l.rsplit('=' in l and '=' or None, 1)
                 amap[alias.strip()] = actual.strip()
--- a/mercurial/crecord.py	Sat May 19 18:45:53 2018 +0530
+++ b/mercurial/crecord.py	Sat May 19 18:47:20 2018 +0530
@@ -554,7 +554,7 @@
     """
     chunkselector = curseschunkselector(headerlist, ui, operation)
     if testfn and os.path.exists(testfn):
-        testf = open(testfn)
+        testf = open(testfn, 'rb')
         testcommands = [x.rstrip('\n') for x in testf.readlines()]
         testf.close()
         while True: