inotify: inotify.server.walk cleanups
authorNicolas Dumazet <nicdumz.commits@gmail.com>
Mon, 04 May 2009 16:43:28 +0900
changeset 8319 1c5d93b225f7
parent 8313 b695392491e7
child 8320 a1305c1c8d8e
inotify: inotify.server.walk cleanups * Removing useless path computation * moving 'reporoot' computation down to the first call to avoid confusion with the parameter used in walkit()
hgext/inotify/server.py
--- a/hgext/inotify/server.py	Fri May 08 16:30:51 2009 +0200
+++ b/hgext/inotify/server.py	Mon May 04 16:43:28 2009 +0900
@@ -59,7 +59,6 @@
 
     # This function is critical to performance during startup.
 
-    reporoot = root == ''
     rootslash = repo.root + os.sep
 
     def walkit(root, reporoot):
@@ -78,7 +77,6 @@
                             break
                     dirs.append(name)
                 elif kind in (stat.S_IFREG, stat.S_IFLNK):
-                    path = join(root, name)
                     files.append((name, kind))
 
             yield hginside, fullpath, dirs, files
@@ -93,7 +91,7 @@
         except OSError, err:
             if err.errno not in walk_ignored_errors:
                 raise
-    for result in walkit(root, reporoot):
+    for result in walkit(root, root == ''):
         yield result[1:]
 
 def _explain_watch_limit(ui, repo, count):