changelog: rename parameters to reflect semantics
authorJoerg Sonnenberger <joerg@bec.de>
Mon, 01 Mar 2021 16:54:51 +0100
changeset 46631 230f73019e49
parent 46630 842f2372ced6
child 46632 9989a276712f
changelog: rename parameters to reflect semantics `read` and `readfiles` can be used with a revision just as well, so follow the naming convention in revlog to reflect this. Differential Revision: https://phab.mercurial-scm.org/D10081
mercurial/changelog.py
--- a/mercurial/changelog.py	Thu Feb 25 21:29:12 2021 +0100
+++ b/mercurial/changelog.py	Mon Mar 01 16:54:51 2021 +0100
@@ -507,7 +507,7 @@
         if not self._delayed:
             revlog.revlog._enforceinlinesize(self, tr, fp)
 
-    def read(self, node):
+    def read(self, nodeorrev):
         """Obtain data from a parsed changelog revision.
 
         Returns a 6-tuple of:
@@ -523,7 +523,7 @@
         ``changelogrevision`` instead, as it is faster for partial object
         access.
         """
-        d, s = self._revisiondata(node)
+        d, s = self._revisiondata(nodeorrev)
         c = changelogrevision(
             d, s, self._copiesstorage == b'changeset-sidedata'
         )
@@ -536,11 +536,11 @@
             text, sidedata, self._copiesstorage == b'changeset-sidedata'
         )
 
-    def readfiles(self, node):
+    def readfiles(self, nodeorrev):
         """
         short version of read that only returns the files modified by the cset
         """
-        text = self.revision(node)
+        text = self.revision(nodeorrev)
         if not text:
             return []
         last = text.index(b"\n\n")