Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
run-tests: open child-parent pipes in binary mode
authorSiddharth Agarwal <sid0@fb.com>
Sat, 10 Nov 2012 11:37:41 -0800
changeset 17925 2631b3576a33
parent 17923 1e6b5faf9d4e
child 17926 65a46635fb31
run-tests: open child-parent pipes in binary mode Python's pickle is a binary format.
tests/run-tests.py file | annotate | diff | comparison | revisions 
--- a/tests/run-tests.py	Mon Nov 12 19:27:03 2012 +0200
+++ b/tests/run-tests.py	Sat Nov 10 11:37:41 2012 -0800
@@ -1071,7 +1071,7 @@
         childopts += ['--tmpdir', childtmp]
         cmdline = [PYTHON, sys.argv[0]] + opts + childopts + job
         vlog(' '.join(cmdline))
-        fps[os.spawnvp(os.P_NOWAIT, cmdline[0], cmdline)] = os.fdopen(rfd, 'r')
+        fps[os.spawnvp(os.P_NOWAIT, cmdline[0], cmdline)] = os.fdopen(rfd, 'rb')
         os.close(wfd)
     signal.signal(signal.SIGINT, signal.SIG_IGN)
     failures = 0
@@ -1155,7 +1155,7 @@
         ignored = len(results['i'])
 
         if options.child:
-            fp = os.fdopen(options.child, 'w')
+            fp = os.fdopen(options.child, 'wb')
             pickle.dump(results, fp, pickle.HIGHEST_PROTOCOL)
             if options.time:
                 pickle.dump(times, fp, pickle.HIGHEST_PROTOCOL)
Mercurial